There is another page that talks about the content of a code review here:
This page talks about the process of doing a code review in GitHub, meaning the series of mouseclicks in the GitHub web interface that you need to do so that the code review “counts”.
Do it like this:
- Go to the
- Scroll through and look at the changes
- If they all look good, click the button
LGTMand click on Approve Changes, i.e.
- Then click (Submit Review).
The animation below shows the process.
Not a code review:
I mean, it is, but not from the standpoint of GitHub. If there are branch protection rules in place that require a code review before the PR can be merged, a comment does not trigger the PR to be mergeable.
Only a properly done code review does.
Here’s an animation emphasizing the wrong way: