Previous Lecture

Lecture 09

Next Lecture

Lecture 09, Tue 01/25

Tue Discussion: Work on team01, H05, H06, H07

Tonight:

• Please meet in your teams and update your status from yesterday; copy your status and update it.

  As a reminder, yesterday, you copied/pasted and then edited this:

  * y/n: Started coding
  * y/n: Controller/Service working in Swagger on localhost
  * y/n: Tests passing on localhost
  * y/n: Instructor tests for my controller/service passing on Gradescope
  * y/n: Mutation testing 25/25 on Gradescope
  * y/n: Pull request made
  * y/n: Pull request code reviewed by another team member
  * y/n: Pull request merged
  

  You can copy/paste your previous post and update it, or copy paste the text above and update it.

  Then, as a team, work on doing code reviews and on merging pull requests.

If your team is finished with team01

… or if you personally have nothing that you can contribute right now, here are three things to work on:

• H05 and H06, which are the last two Java homework assignments from the Head First Java textbook
• H07 which is the first homework assignment that introduces JavaScript.

Working on Homework in Pairs

Note that H05, H06 and H07 are all set up to allow pair submission.

• That is, in theory, you can work together in pairs and submit a single submission from two of you.
• The only reason I say “in theory” is that I’ve never seen anyone do this for an “online homework” assignment; only for programming assignments, and “upload a file” type assignments. So it’s possible that they haven’t enabled this feature for online homework. Let’s hope they have!
• Here are gradescope’s instructions for pair assignments: https://help.gradescope.com/article/m5qz2xsnjy-student-add-group-members

An important point about code reviews

When you do an approving code review, there is a right way and a wrong way.

The wrong way is to simply make comments like this:

This doesn’t trigger GitHub to mark the Pull Request as approved. To trigger that, here’s what you need to do:

1. Click where it says “files changed”

2. Click where it says “Review Changes”

   

3. Click the Approve radio button enter LGTM and then click submit review.

   

Of course, you are also free to either “just comment” or “request changes” if you feel that’s appropriate. But if your intent is to approve, this is the way to go about it.